docs/admin: add OWNERS file with cmd/kubeadm approvers #69984
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
size/S
|
/assign @pwittrock |
| - timothysc | ||
| - fabriziopandini | ||
| labels: | ||
| - kind/documentation |
There was a problem hiding this comment.
Can we also add the SIG label here?
Should it be sig/cluster-lifecycle or sig/docs?cluster-lifecycle makes more sense and reflects the approvers/reviewers. kind/documentation covers the docs part. :)
There was a problem hiding this comment.
hm, if we add sig/cluster-lifecycle it would also apply the label to PRs that touch the kubelet, kube-api-server, cloud-controller-manager, etc files.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/unassign @pwittrock |
| - luxas | ||
| - timothysc | ||
| - fabriziopandini | ||
| reviewers: |
There was a problem hiding this comment.
@neolit123 you should add yourself here ;-)
There was a problem hiding this comment.
@timothysc
the above approver list will sync with the cmd/kubeadm approvers per PR.
also, we should try to get rid of the commits of auto-generated docs in general.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbeda, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
What this PR does / why we need it:
add the cmd/kubeadm approvers to a new OWNERS file that is located in docs/admin.
this ensures that ongoing work for kubeadm will meet approval from kubeadm approvers and would not require docs/OWNERS to be pinged.
the folder also contains files such as kubelet, kube-api-server, cloud-controller-manager, etc which has to change eventually - e.g. a better sub-folder structure.
something else to note is that we should not be committing auto-generated docs in the first place:
#26205 (comment)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):NONE
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?:
@kubernetes/sig-cluster-lifecycle-pr-reviews
/assign @spiffxp
/cc @nikhita @fabriziopandini @timothysc
/kind cleanup