Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 minor fixes for kubeadm upgrade #70055

Merged
merged 2 commits into from
Oct 22, 2018
Merged

2 minor fixes for kubeadm upgrade #70055

merged 2 commits into from
Oct 22, 2018

Conversation

bart0sh
Copy link
Contributor

@bart0sh bart0sh commented Oct 21, 2018

What type of PR is this?

/kind bug

What this PR does / why we need it:

  • Skipped prepulling etcd image if external etcd is used.
  • Fixed missing round bracket

Which issue(s) this PR fixes:

Fixes kubernetes/kubeadm#1136

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 21, 2018
@bart0sh
Copy link
Contributor Author

bart0sh commented Oct 21, 2018

/area kubeadm
/cc @chuckha

@bart0sh
Copy link
Contributor Author

bart0sh commented Oct 21, 2018

/test pull-kubernetes-kubemark-e2e-gce-big

neolit123
neolit123 approved these changes Oct 21, 2018
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks @bart0sh

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2018
@neolit123
Copy link
Member

/assign @fabriziopandini

fabriziopandini
fabriziopandini approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bart0sh good catch!
/approve
/lgtm

fabriziopandini
fabriziopandini approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bart0sh good catch!
/approve
/lgtm

@bart0sh
Copy link
Contributor Author

bart0sh commented Oct 22, 2018

/assign @timothysc

fabriziopandini
fabriziopandini approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bart0sh good catch!
/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bart0sh, fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2018
@k8s-ci-robot k8s-ci-robot merged commit db4c86f into kubernetes:master Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 approved these changes

@fabriziopandini fabriziopandini fabriziopandini approved these changes

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

@chuckha chuckha Awaiting requested review from chuckha

Assignees

@timothysc timothysc

@neolit123 neolit123

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubeadm upgrade has a few minor problems
5 participants
@bart0sh @neolit123 @k8s-ci-robot @fabriziopandini @timothysc