Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e test pod update test flaw #7013

Closed
lavalamp opened this issue Apr 17, 2015 · 2 comments · Fixed by #7297
Closed

e2e test pod update test flaw #7013

lavalamp opened this issue Apr 17, 2015 · 2 comments · Fixed by #7297
Labels
area/test-infra priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@lavalamp
Copy link
Member

https://github.com/GoogleCloudPlatform/kubernetes/blob/master/test/e2e/pods.go#L304

This is wrong because something else could have updated the pod in the mean time, invalidating your resource version. (Specifically, kubelet writes statuses.) It should do a get/update loop that retries as long as it gets a conflict error.

@quinton-hoole to find an owner
@lavalamp lavalamp assigned ghost Apr 17, 2015
@lavalamp lavalamp added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/test-infra labels Apr 17, 2015
@lavalamp lavalamp mentioned this issue Apr 17, 2015
Merged
@ghost
Copy link

ghost commented Apr 21, 2015

PR almost ready - just struggling to get e2e tests to run :-)

@ghost
Copy link

ghost commented Apr 24, 2015

At last.
SUCCESS! -- 5 Passed | 0 Failed | 1 Pending | 34 Skipped I0424 09:04:47.963304 90988 driver.go:96] All tests pass
PR incoming in a few minutes.

@ghost ghost mentioned this issue Apr 24, 2015
Merged
@ghost ghost closed this as completed in #7297 Apr 24, 2015
@lavalamp lavalamp unassigned ghost Aug 12, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/test-infra priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Retry pod update on version conflict error in e2e test.
1 participant
@lavalamp