retrofit svcacct token authenticator to support audience validation #70157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
mikedanese
commented
Oct 24, 2018
|
/assign @caesarxuchao |
|
/assign @liggitt |
awly
reviewed
Nov 1, 2018
k8s-ci-robot
added
size/L
k8s-ci-robot
added
size/M
mikedanese
force-pushed
the
trev1
branch
2 times, most recently
from
73f4f70
to
ba9d89d
Compare
|
@awly fixed. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikedanese The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
cjcullen
reviewed
Nov 15, 2018
| @@ -170,14 +172,34 @@ func (j *jwtTokenAuthenticator) AuthenticateToken(ctx context.Context, tokenData | |||
| return nil, false, utilerrors.NewAggregate(errlist) | |||
| } | |||
|
|
|||
| tokenAudiences := authenticator.Audiences(public.Audience) | |||
| if len(tokenAudiences) == 0 { | |||
| // only apiserver audiences are allowed for legacy tokens | |||
There was a problem hiding this comment.
Should this comment be // tokens with no audience (legacy tokens) implicitly have the apiserver audience.
|
|
||
| requestedAudiences, ok := authenticator.AudiencesFrom(ctx) | ||
| if !ok { | ||
| // default to apiserver audiences |
There was a problem hiding this comment.
// requests that don't explicitly request an audience are requesting the implicit apiserver audience.
| requestedAudiences = j.implicitAuds | ||
| } | ||
|
|
||
| auds := authenticator.Audiences(tokenAudiences).Intersect(requestedAudiences) |
There was a problem hiding this comment.
matchingAudiences := ...? Up to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind feature
/sig auth
#69893
@kubernetes/sig-auth-pr-reviews