Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace resyncTicker with syncTicker in comment #70162

Merged
merged 1 commit into from Nov 6, 2018
Merged

Replace resyncTicker with syncTicker in comment #70162

merged 1 commit into from Nov 6, 2018

Conversation

MIBc
Copy link
Contributor

@MIBc MIBc commented Oct 24, 2018

What type of PR is this?

What this PR does / why we need it:
The variable resyncTicker in comment is out of date. It is replaced with syncTicker.

Does this PR introduce a user-facing change?:
NONE

@MIBc
Replace resyncTicker with syncTicker in commenting
06a3391 
The variable resyncTicker in commenting is out of date. It is replaced with syncTicker.
@k8s-ci-robot
Copy link
Contributor

@MIBc: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 24, 2018
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 24, 2018
@neolit123
Copy link
Member

/kind cleanup
/ok-to-test
/lgtm
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 24, 2018
@MIBc
Copy link
Contributor Author

MIBc commented Oct 25, 2018

/retest

@MIBc
Copy link
Contributor Author

MIBc commented Oct 25, 2018

/assign @Random-Liu

@nikhita
Copy link
Member

nikhita commented Nov 5, 2018

/assign @yujuhong
for approval

@yujuhong
Copy link
Contributor

yujuhong commented Nov 6, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MIBc, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2018
@k8s-ci-robot k8s-ci-robot merged commit 160ebd3 into kubernetes:master Nov 6, 2018
@MIBc MIBc deleted the commenting-error branch November 8, 2018 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@resouer resouer resouer approved these changes

@vishh vishh Awaiting requested review from vishh

Assignees

@neolit123 neolit123

@Random-Liu Random-Liu

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@MIBc @k8s-ci-robot @neolit123 @nikhita @yujuhong @resouer @Random-Liu