-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kubeadm/app/cmd]switch to github.com/pkg/errors #70186
Conversation
I have done the packages as follows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thank you for doing this!
/ok-to-test |
@yuexiao-wang you will likely need to run ./hack/update-bazel.sh |
/retest Review the full test history for this PR. Silence the bot with an |
also the PR needs a re-base as the code has changed. thanks. |
/retest Review the full test history for this PR. Silence the bot with an |
/lgtm cancel to stop the bot auto-test until the conflicts are resolved. |
d28873c
to
c21d52b
Compare
c21d52b
to
3158da3
Compare
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3158da3
to
2a55569
Compare
sorry, I forgot to run update-bazel.sh after modify codes. |
2a55569
to
ab086ed
Compare
ab086ed
to
5c40222
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timothysc, yuexiao-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c574a51
to
f9084c6
Compare
Signed-off-by: yuexiao-wang <wang.yuexiao@zte.com.cn>
CT is green. |
thank you @yuexiao-wang |
Signed-off-by: yuexiao-wang wang.yuexiao@zte.com.cn
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
switch to github.com/pkg/errors
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes # kubernetes/kubeadm#1183
Special notes for your reviewer:
Does this PR introduce a user-facing change?: