Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increment version for metadata-concealment test image #70195

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Increment version for metadata-concealment test image #70195

merged 1 commit into from
Oct 25, 2018

Conversation

dekkagaijin
Copy link
Contributor

Follow-up to #69593, incrementing the test image version as well as the corresponding test manifest entry.

make -C test/images all-push WHAT=metadata-concealment was successfully executed to push the new image manifest.

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 24, 2018
@dekkagaijin
Copy link
Contributor Author

@ixdy PTAL

@ixdy
Copy link
Member

ixdy commented Oct 24, 2018

/lgtm
/approve
/ok-to-test

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dekkagaijin, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2018
ixdy
ixdy reviewed Oct 24, 2018
View reviewed changes
test/images/metadata-concealment/VERSION
@@ -1 +1 @@
1.0
1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you cherry-pick this to a release branch, you'll either want to make sure you include the changes from #69593 too, or drop this change to VERSION.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

roger

@ixdy
Copy link
Member

ixdy commented Oct 24, 2018

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 24, 2018
@k8s-ci-robot k8s-ci-robot merged commit 375ff10 into kubernetes:master Oct 25, 2018
This was referenced Oct 25, 2018
Closed
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 1, 2018
@k8s-ci-robot
Merge pull request #70307 from dekkagaijin/automated-cherry-pick-of-#…
6278e61 
…69593-#70195-#70253-upstream-release-1.12

Automated cherry pick of #69593: account for disabled legacy metadata endpoints #70195: Increment version for metadata-concealment test image #70253: always allow unimportant legacy root paths
@dekkagaijin dekkagaijin mentioned this pull request Apr 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixdy ixdy ixdy left review comments

@luxas luxas Awaiting requested review from luxas

Assignees

@ixdy ixdy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dekkagaijin @ixdy @k8s-ci-robot