-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map allocation optimization for client-go/tools/cache #70234
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I requested the CLA to sign it but I did not receive the email. I asked for a resend but figured I would PR this trivial changes already so that it can be reviewed. |
Initial allocation of several maps as the sizes are known Signed-off-by: Adrián Orive <adrian.orive.oneca@gmail.com>
Edited the title, signed the CLA, squashed the 3 commits into 1 and signed it. Should be ready to merge now. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Everything seems to be fine (expected on a trivial PR). What is the next step? |
it's in the merge queue. the bots will take it from here. thanks! |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Pre-allocates 3 maps in different
Replace
methods that are being created from a slice, so the size is known beforehand.Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
The optimization may be really small but it is good practice to pre-allocate in such cases.
Does this PR introduce a user-facing change?: