Add regions ap-northeast-3 and eu-west-3 to AWS cloud provider #70252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
cncf-cla: yes
nckturner
changed the title
|
/approve /retest And FYI it happens on the ECR validation - without this PR, an instance in another region won't recognize an ECR image in e.g. (I'm not entirely sure why we don't do a DescribeRegions call though... I think it's because it wasn't in the kube-up AWS IAM policy, though I think kops has it for other reasons) |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, nckturner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/sig aws
What this PR does / why we need it:
Add regions ap-northeast-3 and eu-west-3 to the list of well known AWS regions.
Does this PR introduce a user-facing change?:
NONE. The aws cloudprovider can discover unknown regions from instance metadata. Although, in the case that we are not running on an ec2 instance and have not configured a region, but still need to validate whether a region is correct, then we can validate these newer regions correctly, though I don't know when this would happen.