validate args for kubectl config view #70413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
needs-ok-to-test
|
/cc @soltysh |
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/assign @adohe |
soltysh
requested changes
Nov 1, 2018
pkg/kubectl/cmd/config/view.go
Outdated
| func (o *ViewOptions) Complete(cmd *cobra.Command) error { | ||
| func (o *ViewOptions) Complete(cmd *cobra.Command, args []string) error { | ||
| if len(args) != 0 { | ||
| return cmdutil.UsageErrorf(cmd, "unexpected args: %v", args) |
There was a problem hiding this comment.
We should probably say use full "arguments" here, the same applies to pkg/kubectl/cmd/apiresources/apiversions.go and pkg/kubectl/cmd/apiresources/apiresources.go would you mind fixing the other two as well?
There was a problem hiding this comment.
Thanks!
Updated, please take a look.
Pingan2017
force-pushed
the
kubectl-config-view
branch
from
95dcdeb
to
f824b58
Compare
k8s-ci-robot
added
size/S
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Pingan2017, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/milestone v1.13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/sig cli
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # kubernetes/kubectl#386
Special notes for your reviewer:
Does this PR introduce a user-facing change?: