Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick metadata-agent psp binding #70497

Merged
merged 1 commit into from
Dec 3, 2018
Merged

Cherry-pick metadata-agent psp binding #70497

merged 1 commit into from
Dec 3, 2018

Conversation

tallclair
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
Cherry-pick the PodSecurityPolicy binding for the metadata-agent addon to release-1.11. This is required for the metadata-agent to work with PodSecurityPolicy.

Special notes for your reviewer:

The master change was added across a number of commits that moved the file around, so rather than cherrypicking each commit individually, I only grabbed the end-result. See https://github.com/kubernetes/kubernetes/tree/master/cluster/addons/metadata-agent/stackdriver/podsecuritypolicies

Does this PR introduce a user-facing change?:

NONE

/sig gcp

/assign @davidebelloni @kawych @foxish

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note-none Denotes a PR that doesn't merit a release note. labels Oct 31, 2018
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/gcp labels Oct 31, 2018
@k8s-ci-robot
Copy link
Contributor

@tallclair: GitHub didn't allow me to assign the following users: davidebelloni.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

What type of PR is this?
/kind bug

What this PR does / why we need it:
Cherry-pick the PodSecurityPolicy binding for the metadata-agent addon to release-1.11. This is required for the metadata-agent to work with PodSecurityPolicy.

Special notes for your reviewer:

The master change was added across a number of commits that moved the file around, so rather than cherrypicking each commit individually, I only grabbed the end-result. See https://github.com/kubernetes/kubernetes/tree/master/cluster/addons/metadata-agent/stackdriver/podsecuritypolicies

Does this PR introduce a user-facing change?:

NONE

/sig gcp

/assign @davidebelloni @kawych @foxish

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 31, 2018
@tallclair tallclair mentioned this pull request Oct 31, 2018
Merged
@kawych
Copy link
Contributor

kawych commented Nov 2, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2018
@kawych
Copy link
Contributor

kawych commented Nov 2, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kawych, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2018
@tallclair
Copy link
Member Author

/retest

1 similar comment
@tallclair
Copy link
Member Author

/retest

@tallclair
Copy link
Member Author

ping @foxish for cherrypick approval

@foxish foxish added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Dec 3, 2018
@foxish foxish added this to the v1.11 milestone Dec 3, 2018
@k8s-ci-robot k8s-ci-robot merged commit 9df1ee0 into kubernetes:release-1.11 Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kawych kawych Awaiting requested review from kawych

@piosz piosz Awaiting requested review from piosz

Assignees

@foxish foxish

@kawych kawych

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tallclair @k8s-ci-robot @kawych @foxish