Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding test case for flex volume resize on pod restart #70667

Merged
merged 1 commit into from
Nov 7, 2018
Merged

adding test case for flex volume resize on pod restart #70667

merged 1 commit into from
Nov 7, 2018

Conversation

aniket-s-kulkarni
Copy link
Contributor

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

This PR adds a follow up test case to Flex volume resizing PR as discussed in the review comments

Which issue(s) this PR fixes

None; it just adds a supplementary e2e test case

Special notes for your reviewer:

@gnufied @chakri-nelluri this adds the extra e2e test that we discussed about. Refer #67851 (comment)

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot
Copy link
Contributor

@aniket-s-kulkarni: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 5, 2018
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 5, 2018
@aniket-s-kulkarni
Copy link
Contributor Author

/assign @gnufied
/assign @chakri-nelluri

@aniket-s-kulkarni
Copy link
Contributor Author

/sig sig-storage

@gnufied
Copy link
Member

gnufied commented Nov 5, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 5, 2018
@aniket-s-kulkarni
Copy link
Contributor Author

/retest

@gnufied
Copy link
Member

gnufied commented Nov 6, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2018
@gnufied
Copy link
Member

gnufied commented Nov 6, 2018

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 6, 2018
@gnufied
Copy link
Member

gnufied commented Nov 7, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aniket-s-kulkarni, gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2018
@chakri-nelluri
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit ebcc2c7 into kubernetes:master Nov 7, 2018
@AishSundar
Copy link
Contributor

@aniket-s-kulkarni this new test is failing in release-blocking and sig-storage dashboards since it was introduced this afternoon

Can you look into this as priority please?
@jberkus @maria @mortent

@mortent mortent mentioned this pull request Nov 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 Awaiting requested review from davidz627

@verult verult Awaiting requested review from verult

Assignees

@gnufied gnufied

@chakri-nelluri chakri-nelluri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aniket-s-kulkarni @k8s-ci-robot @gnufied @chakri-nelluri @AishSundar