Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl: remove redundant test #70883

Merged
merged 1 commit into from
Nov 10, 2018

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Nov 9, 2018

helps fix:
kubernetes/kubectl#80

NONE

/sig cli
/kind cleanup
/area kubectl
/assign

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 9, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/cli Categorizes an issue or PR as relevant to SIG CLI. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2018
@seans3
Copy link
Contributor Author

seans3 commented Nov 9, 2018

/cc @soltysh
/cc @apelisse

@apelisse
Copy link
Member

apelisse commented Nov 9, 2018

LGTM, you have to update bazel BUILD file

@seans3
Copy link
Contributor Author

seans3 commented Nov 9, 2018

/cc @juanvallejo

@juanvallejo
Copy link
Contributor

juanvallejo commented Nov 9, 2018

@seans3 I think we should move these two test cases to https://github.com/kubernetes/cli-runtime/blob/master/pkg/genericclioptions/printers/sourcechecker_test.go. We can also just delete the customcolumn printer pieces from this file

Nevermind, I see it's using the internal api

@juanvallejo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2018
@soltysh
Copy link
Contributor

soltysh commented Nov 9, 2018

/priority cleanup
/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 9, 2018
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 2dcdad2 into kubernetes:master Nov 10, 2018
@seans3 seans3 deleted the printing-test-remove branch November 12, 2018 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants