Fix a race in the scheduler. #70892
Merged
Fix a race in the scheduler. #70892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/retest |
mikedanese
added
priority/critical-urgent
|
/assign |
|
/retest |
Huang-Wei
reviewed
Nov 9, 2018
Loop over priorityConfigs seperately. The node loop can only safely modify result[i][index]. Before this change it sometimes modified result[i] concurrently with other loops. Fixes: 7164967 ==================== Test output for //pkg/scheduler/core:go_default_test: ================== WARNING: DATA RACE Read at 0x00c0005e8ed0 by goroutine 22: k8s.io/kubernetes/pkg/scheduler/core.PrioritizeNodes.func2() pkg/scheduler/core/generic_scheduler.go:667 +0x2ea k8s.io/kubernetes/vendor/k8s.io/client-go/util/workqueue.ParallelizeUntil.func1() staging/src/k8s.io/client-go/util/workqueue/parallelizer.go:65 +0x9e Previous write at 0x00c0005e8ed0 by goroutine 21: k8s.io/kubernetes/pkg/scheduler/core.PrioritizeNodes.func2() pkg/scheduler/core/generic_scheduler.go:668 +0x450 k8s.io/kubernetes/vendor/k8s.io/client-go/util/workqueue.ParallelizeUntil.func1() staging/src/k8s.io/client-go/util/workqueue/parallelizer.go:65 +0x9e Goroutine 22 (running) created at: k8s.io/kubernetes/vendor/k8s.io/client-go/util/workqueue.ParallelizeUntil() staging/src/k8s.io/client-go/util/workqueue/parallelizer.go:57 +0x1a3 k8s.io/kubernetes/pkg/scheduler/core.PrioritizeNodes() pkg/scheduler/core/generic_scheduler.go:682 +0x592 k8s.io/kubernetes/pkg/scheduler/core.(*genericScheduler).Schedule() pkg/scheduler/core/generic_scheduler.go:186 +0x77d k8s.io/kubernetes/pkg/scheduler/core.TestGenericScheduler.func1() pkg/scheduler/core/generic_scheduler_test.go:464 +0x91f testing.tRunner() GOROOT/src/testing/testing.go:827 +0x162 Goroutine 21 (running) created at: k8s.io/kubernetes/vendor/k8s.io/client-go/util/workqueue.ParallelizeUntil() staging/src/k8s.io/client-go/util/workqueue/parallelizer.go:57 +0x1a3 k8s.io/kubernetes/pkg/scheduler/core.PrioritizeNodes() pkg/scheduler/core/generic_scheduler.go:682 +0x592 k8s.io/kubernetes/pkg/scheduler/core.(*genericScheduler).Schedule() pkg/scheduler/core/generic_scheduler.go:186 +0x77d k8s.io/kubernetes/pkg/scheduler/core.TestGenericScheduler.func1() pkg/scheduler/core/generic_scheduler_test.go:464 +0x91f testing.tRunner() GOROOT/src/testing/testing.go:827 +0x162 ================== --- FAIL: TestGenericScheduler (0.01s) --- FAIL: TestGenericScheduler/test_6 (0.00s) testing.go:771: race detected during execution of test testing.go:771: race detected during execution of test FAIL
Huang-Wei
approved these changes
Nov 9, 2018
k8s-ci-robot
added
the
lgtm
bsalamat
approved these changes
Nov 9, 2018
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bsalamat, mikedanese The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loop over priorityConfigs seperately. The node loop can only safely
modify result[i][index]. Before this change it sometimes modified
result[i] concurrently with other loops.
Verified with
go test -race -run=TestGenericScheduler/test_6 -test.v -count 1000 ./pkg/scheduler/core/kind bug
/sig scheduling