Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix function comment to consistent with its name #70903

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Fix function comment to consistent with its name #70903

merged 1 commit into from
Feb 11, 2019

Conversation

ping035627
Copy link
Contributor

@ping035627 ping035627 commented Nov 10, 2018 •
edited

What type of PR is this?
/kind cleanup

**What this PR does / why we need it: **
Fix function comment to consistent with its name.

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

release-note
NONE

@ping035627
Fix function comment
7750422 
Signed-off-by: PingWang <wang.ping5@zte.com.cn>
@k8s-ci-robot
Copy link
Contributor

@ping035627: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 10, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @ping035627. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 10, 2018
@justinsb
Copy link
Member

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 10, 2018
@fedebongio
Copy link
Contributor

/assign @yliaog

@yliaog
Copy link
Contributor

yliaog commented Nov 12, 2018

/lgtm

@ping035627
Copy link
Contributor Author

@yliaog Excuse me, can this pr be merged? Need approved label. Thanks.

@ping035627
Copy link
Contributor Author

/release-note-none
/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 15, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 15, 2018
@ping035627
Copy link
Contributor Author

@justinsb Excuse me, can this pr be merged? Need approved label. Thanks.

@k82cn
Copy link
Member

k82cn commented Dec 3, 2018

/lgtm
/approve

@ping035627
Copy link
Contributor Author

@k82cn the approve label doesn't work, can you help to see what's going on?

@k82cn
Copy link
Member

k82cn commented Dec 4, 2018

I'm not in approver list staging/src/k8s.io/apiserver/OWNERS :)

@ping035627
Copy link
Contributor Author

@lavalamp Excuse me, can this pr be merged? Need approved label. Thanks.

@ping035627
Copy link
Contributor Author

@deads2k hi, can you review this pr? Need approved label. Thanks.

@ping035627 ping035627 closed this Feb 11, 2019
@sttts sttts reopened this Feb 11, 2019
@sttts
Copy link
Contributor

sttts commented Feb 11, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, ping035627, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit d820b50 into kubernetes:master Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maheshwarigagan maheshwarigagan maheshwarigagan approved these changes

@resouer resouer Awaiting requested review from resouer

@sttts sttts Awaiting requested review from sttts

Assignees

@justinsb justinsb

@sttts sttts

@k82cn k82cn

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@ping035627 @k8s-ci-robot @justinsb @fedebongio @yliaog @k82cn @sttts @maheshwarigagan