Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup pkg/ssh #70940

Merged
merged 1 commit into from
Dec 5, 2018
Merged

cleanup pkg/ssh #70940

merged 1 commit into from
Dec 5, 2018

Conversation

mikedanese
Copy link
Member

unexport some of the public API and delete unused

/kind cleanup
/sig apimachinery

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 12, 2018
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 12, 2018
@mikedanese
cleanup pkg/ssh
bcd4597 
unexport some of the public API and delete unused
@brendandburns
Copy link
Contributor

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2018
@fedebongio
Copy link
Contributor

/assign @cheftako

@mikedanese mikedanese added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Nov 12, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 12, 2018
@mikedanese
Copy link
Member Author

mikedanese commented Dec 5, 2018 •
edited

@brendanburns FYI, /lgtm no longer implies /approve. Adding label since you are an approver here.

@mikedanese mikedanese added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mikedanese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mikedanese
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 3952199 into kubernetes:master Dec 5, 2018
@mikedanese mikedanese deleted the sshcleanup branch December 5, 2018 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@cheftako cheftako

@brendandburns brendandburns

@cjcullen cjcullen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mikedanese @brendandburns @fedebongio @k8s-ci-robot @cheftako @cjcullen