-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e/storage: avoid fmt.Sprintf for single string #70989
e2e/storage: avoid fmt.Sprintf for single string #70989
Conversation
The fmt.Sprintf call is either redundant (if the format string contains no format characters) or broken (if it does, because there are no parameters).
@pohly: GitHub didn't allow me to request PR reviews from the following users: mkimuram. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
GetDriverNameWithFeatureTags just returns the resut of fmt.Sprintf as https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/drivers/base.go#L99 /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone v1.13 |
/priority backlog |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The fmt.Sprintf call is either redundant (if the format string
contains no format characters) or broken (if it does, because there
are no parameters).
Does this PR introduce a user-facing change?:
/sig storage
/assign @msau42
/cc @mkimuram