rootcacertpublisher: trigger resync on namespace add and update #71005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last cleanup was a bit overzealous.
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikedanese The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
While I verify. /hold |
k8s-ci-robot
added
do-not-merge/hold
mikedanese
added
the
priority/important-soon
k8s-ci-robot
removed
the
needs-priority
|
/retest |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
mikedanese
commented
Nov 14, 2018
| @@ -62,6 +62,12 @@ func NewPublisher(cmInformer coreinformers.ConfigMapInformer, cl clientset.Inter | |||
| e.cmLister = cmInformer.Lister() | |||
| e.cmListerSynced = cmInformer.Informer().HasSynced | |||
|
|
|||
| nsInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{ | |||
| AddFunc: e.namespaceAdded, | |||
| UpdateFunc: e.namespaceUpdated, | |||
There was a problem hiding this comment.
Without registering these event handlers, namespaceAdded and namespaceUpdated are not called, so we don't resync the ca.crt config map on namespace changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last cleanup was a bit overzealous.
/kind bug
/sig auth