Fixup language on help message to denote phases #71009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothysc
added
priority/important-soon
|
@timothysc: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
timothysc
added
release-note-none
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold I'll use this PR to bundle up other CLI issues. |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
removed
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
timothysc
added
the
lgtm
neolit123
reviewed
Nov 14, 2018
| @@ -61,7 +61,7 @@ func NewBootstrapTokenPhase() workflow.Phase { | |||
| return workflow.Phase{ | |||
| Name: "bootstrap-token", | |||
| Aliases: []string{"bootstraptoken"}, | |||
| Short: bootstrapTokenLongDesc, | |||
| Short: "Generates bootstrap tokens used to join a node to a cluster", | |||
There was a problem hiding this comment.
i think this makes the var unused.
|
/retest |
Signed-off-by: Timothy St. Clair <timothysc@gmail.com>
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
size/S
|
/lgtm |
k8s-ci-robot
added
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Fixup language on help message to denote phases. The help message to the user, was more confusing than anything.
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?:
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews