-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove test/integration/* from hack/.golint_failures #71022
Conversation
Hi @emwalker. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
9753c53
to
eddd43b
Compare
/assign @eparis |
/ok-to-test |
/lgtm |
eddd43b
to
c07cfe4
Compare
/lgtm |
c07cfe4
to
7f68bb2
Compare
7f68bb2
to
fd576df
Compare
/lgtm |
ping @eparis for approval |
nice work, /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: emwalker, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Oops, the commit 0e1d50e has added a new function DefaultOpenAPIConfig() which is against golint before merging this patch. |
/retest Review the full test history for this PR. Silence the bot with an |
1 similar comment
/retest Review the full test history for this PR. Silence the bot with an |
/hold for stopping unnecessary CI |
@oomichi — sure, I'll rebase and fix the golint error shortly. |
fd576df
to
75df4dc
Compare
/lgtm |
/hold cancel Thanks |
/test pull-kubernetes-integration |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Fixes golint errors in several files under test/integration/.
Which issue(s) this PR fixes
See #68026 for more information.
Does this PR introduce a user-facing change?: