-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CreateSecPodWithNodeName to properly set node to be deployed #71039
Conversation
Hi @mkimuram. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Manifest for the pod inside the daemonset for csi-hostpath plugin is changed by patching with PatchCSIOptions, as a result, csi-hostpath pod only deployed in |
/ok-to-test |
/retest |
/priority important-soon |
/retest |
@msau42 @gnufied @davidz627 @AishSundar @jberkus This will partially fix #70760 . Could you approve or assign someone approve this? |
/assign @saad-ali |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkimuram, msau42, saad-ali The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-integration |
/retest Review the full test history for this PR. Silence the bot with an |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Fix CreateSecPodWithNodeName to properly set node to be deployed.
This bug cause
[Testpattern: Dynamic PV (filesystem volmode)] volumeMode[Feature:BlockVolume] should create sc, pod, pv, and pvc, read/write to the pv, and delete all created resources
test forcsi-hostpath
driver fail.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):This only address csi hostpath test for 70760.
Special notes for your reviewer:
/sig storage
Does this PR introduce a user-facing change?: