Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubeadm phases - add local flags #71040

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Kubeadm phases - add local flags #71040

merged 1 commit into from
Nov 15, 2018

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR introduce local flags for phases.

Which issue(s) this PR fixes :

xref: kubernetes/kubeadm#1206 part2

Special notes for your reviewer:

Now the options for adding flags to phases are:

  • global flags (this is managed by cobra)
  • inherited (explicit opt-in) from following set of flags:
    • local flags defined in the parent command
    • additional flags defined in the phase runner (NB not applied to the parent command)
  • local flags (NB. not shared among phases)

Phases are updated accordingly

/sig cluster-lifecycle
/kind bug
/assign @timothysc
/assign @neolit123
@kubernetes/sig-cluster-lifecycle-pr-reviews
@liztio

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 14, 2018
@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Nov 14, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 14, 2018
@k8s-ci-robot k8s-ci-robot added area/kubeadm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 14, 2018
@neolit123
Copy link
Member

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 14, 2018
@timothysc timothysc added this to the v1.13 milestone Nov 14, 2018
neolit123
neolit123 approved these changes Nov 14, 2018
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

thanks for the update @fabriziopandini .
maybe someone else can test once we merge it.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 14, 2018
timothysc
timothysc approved these changes Nov 14, 2018
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gr8!
/lgtm
/approve

@liztio after this merges you should be unblocked!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

liztio
liztio approved these changes Nov 14, 2018
View reviewed changes
Copy link
Contributor

@liztio liztio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for the fast turnaround @fabriziopandini!

@timothysc
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2018
@liztio
Copy link
Contributor

liztio commented Nov 14, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2018
@timothysc timothysc added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 14, 2018
@k8s-ci-robot k8s-ci-robot merged commit bb2fcd9 into kubernetes:master Nov 15, 2018
@fabriziopandini fabriziopandini deleted the kubeadm-phases-local-flags branch December 15, 2018 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothysc timothysc timothysc approved these changes

@neolit123 neolit123 neolit123 approved these changes

@liztio liztio liztio approved these changes

@dixudx dixudx Awaiting requested review from dixudx

@kad kad Awaiting requested review from kad

Assignees

@timothysc timothysc

@neolit123 neolit123

@liztio liztio

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fabriziopandini @neolit123 @k8s-ci-robot @timothysc @liztio