Propagate panics up handler chain #71076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
/assign lavalamp sttts |
k8s-ci-robot
added
sig/api-machinery
k8s-ci-robot
added
the
approved
|
/priority critical-urgent |
k8s-ci-robot
added
priority/critical-urgent
liggitt
force-pushed
the
preserve-stack
branch
from
e295a2f
to
0b39f63
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
liggitt
force-pushed
the
preserve-stack
branch
from
0b39f63
to
57e7e3c
Compare
sttts
reviewed
Nov 15, 2018
| const size = 64 << 10 | ||
| buf := make([]byte, size) | ||
| buf = buf[:goruntime.Stack(buf, false)] | ||
| panicReason = fmt.Sprintf("%v\n%s", panicReason, string(buf)) |
There was a problem hiding this comment.
Makes concatenation of further backtraces cleaner
liggitt
force-pushed
the
preserve-stack
branch
from
57e7e3c
to
0952c9e
Compare
|
/milestone v1.13 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
1 similar comment
|
/retest |
|
/cc @roycaihw |
This was referenced Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes panic propagation in
finishRequest. finishRequest incorrectly assumed that HandleCrash was the correct way to recover a panic in order to propagate it up the handler chain. In actuality, HandleCrash simply logs and repanics, which causes the process to exit in finishRequest, which means we don't get the full call stack. We want to capture the panic reason/stack, and propagate it upward so the full stack is logged at the top of the handler chain.Special notes for your reviewer:
Does this PR introduce a user-facing change?: