e2e/framework: capture logs only from pods that actually started #71210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to retrieve logs for a container that hasn't started yet may have been the reason for the "the server does not allow this method on the requested resource" error that showed up on the GCE CI test cluster (issue kubernetes#70888). If we wait with retrieving logs until the pod is running or has terminated, then we might be able to avoid that error. It's the right thing to do either way and not complicated to implement.
k8s-ci-robot
added
release-note-none
|
/sig storage |
k8s-ci-robot
added
sig/storage
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ixdy, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@AishSundar test framework change only for v1.13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
On some clusters there are a lot of log messages about pod log retrieval, which makes debugging hard because the test output becomes quite large. This PR might avoid the failing operation and thus the extra output.
Even if it doesn't, not attempting an operation that's just bound to fail is a useful optimization.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #70888
Special notes for your reviewer:
Does this PR introduce a user-facing change?: