kubeadm: fix issues in the v1beta1 godoc #71219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
kind/bug
- make the whole config example actually pass strict verification (i.e. make the config work with --config) - add print init-defaults/join defaults - other small fixes
neolit123
force-pushed
the
kubeadm-go-docs-1.13
branch
from
4d48a08
to
bc6837f
Compare
fabriziopandini
approved these changes
Nov 19, 2018
There was a problem hiding this comment.
Thanks @neolit123 !
This will help contributors in testing change before release!
/approve
/lgtm
/milestone v1.13
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
yagonobre
approved these changes
Nov 19, 2018
|
/test pull-kubernetes-kubemark-e2e-gce-big |
|
/test pull-kubernetes-integration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind documentation
What this PR does / why we need it:
(i.e. make the config work with --config)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes kubernetes/kubeadm#1255
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?:
/assign @fabriziopandini @rosti
/priority critical-urgent
@kubernetes/sig-cluster-lifecycle