kubeadm: override node registration options from command line

[bart0sh]

What type of PR is this?

/kind bug

What this PR does / why we need it:

'kubeadm join' silently ignores --node-name and --cri-socket
command line options if --config option is specified.

In some cases it's much easier for users to override these parameters
from the command line instead of updating config, especially for
multi-node automatic deployments where only node name should be changed.

Implemented setting 'name' and 'criSocket' options from the command
line even if --config command line option is used.

Special notes for your reviewer:

You can see more details in [this comment](url
kubernetes/kubeadm#857 (comment))

Does this PR introduce a user-facing change?:

kubeadm join correctly uses --node-name and --cri-socket when --config option is also used

[bart0sh]

/cc @neolit123 @seh

[k8s-ci-robot]

@bart0sh: GitHub didn't allow me to request PR reviews from the following users: seh.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @neolit123 @seh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[neolit123]

/retest

[neolit123]

thanks @bart0sh

[timothysc]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bart0sh, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cmd/kubeadm/OWNERS [timothysc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nikopen]

/lgtm

[bart0sh]

/retest

[bart0sh]

/test pull-kubernetes-integration

[seh]

@bart0sh, by my reading of kubeadm/app/util/config.ConfigFileAndDefaultsToInternalConfig, as used by kubeadm init, it only takes the --node-name flag into account when the --config flag isn't used, as was the case you fixed here with kubeadm join. Should we fix kubeadm init similarly?

With your fix, I no longer need to patch my JoinConfiguration file on each worker node, but I do still need to patch my InitConfiguration file on the masters.

[neolit123]

we should probably add that too @bart0sh what you think?
let me know if you don't have the time and i can send a PR this week.

[bart0sh]

@seh, @neolit123 I'll try to fix it. Thanks for pointing this out!

[neolit123]

@bart0sh thank you! ping me on slack if you have any questions.

[bart0sh]

sorry for not fixing it in 'kubeadm init'. I somehow assumed from this post that it's 'kubeadm join' issue.

[seh]

That's my fault for complaining profusely about the problem in front of my face, but not complaining enough about the next problem I'd run into once the first problem was solved.

[neolit123]

@bart0sh
no problem.
BTW we need the PR for today, because the new beta is tomorrow. LMK if i should take it.

[bart0sh]

@neolit123 yep, working on it.