Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github.com/json-iterator/go to 1.1.4 #71296

Merged
merged 1 commit into from
Nov 21, 2018
Merged

Update github.com/json-iterator/go to 1.1.4 #71296

merged 1 commit into from
Nov 21, 2018

Conversation

cblecker
Copy link
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Updates this dependency to use the tagged v1.1.4. No actual go code changes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #66422

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 21, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 21, 2018
@cblecker cblecker added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Nov 21, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 21, 2018
@cblecker cblecker added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 21, 2018
@cblecker
Copy link
Member Author

/assign @dims

@cblecker
Copy link
Member Author

/assign @nikhita

@dims
Copy link
Member

dims commented Nov 21, 2018

no code changes FTW!!!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2018
@cblecker
Copy link
Member Author

/retest

nikhita
nikhita reviewed Nov 21, 2018
View reviewed changes
Godeps/Godeps.json
"Comment": "1.1.3-22-gf2b4162afba355",
"Rev": "f2b4162afba35581b6d4a50d3b8f34e33c144682"
"Comment": "1.1.4",
"Rev": "ab8a2e0c74be9d3be70b3184d9acc634935ded82"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure I'm probably missing something here but doesn't the commit json-iterator/go@ab8a2e0 contain code changes?

Copy link
Member Author

@cblecker cblecker Nov 21, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It changes things in the github.com/json-iterator/go/extra package, but that's not imported by the main github.com/json-iterator/go package, so we don't vendor it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nikhita nikhita mentioned this pull request Nov 21, 2018
Closed
@cblecker
Copy link
Member Author

@AishSundar As this has no changes to go code, and will ease downstream vendoring of kubernetes (improves the release), I'm going to tag this into v1.13.

/milestone v1.13
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 21, 2018
@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 21, 2018
@cblecker cblecker added kind/bug Categorizes issue or PR as related to a bug. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/bug Categorizes issue or PR as related to a bug. labels Nov 21, 2018
@k8s-ci-robot k8s-ci-robot merged commit 18619f0 into kubernetes:master Nov 21, 2018
@cblecker cblecker deleted the json-iterator-bump branch November 21, 2018 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@dims dims

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

Request to bump "json-iterator/go" dependency to 1.1.4
4 participants
@cblecker @k8s-ci-robot @dims @nikhita