kubeadm: override node registration options from command line (follow-up)

[bart0sh]

What type of PR is this?

/kind bug

What this PR does / why we need it:

It turned out after the discussion in the similar PR that 'kubeadm init' also suffers from this issue. This fix is almost identical to the previous one:

'kubeadm init' silently ignores --node-name and --cri-socket
command line options if --config option is specified.

Implemented setting 'name' and 'criSocket' options from the command
line even if --config command line option is used.

Does this PR introduce a user-facing change?:

kubeadm init correctly uses --node-name and --cri-socket when --config option is also used

[bart0sh]

/cc @neolit123
/cc @seh

[k8s-ci-robot]

@bart0sh: GitHub didn't allow me to request PR reviews from the following users: seh.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @neolit123
/cc @seh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[neolit123]

@bart0sh thanks a lot
will double check it locally with git am just in case.

/lgtm
/priority critical-urgent
/kind bug

[neolit123]

/assign @fabriziopandini @timothysc
/retest

[neolit123]

will double check it locally with git am just in case.

tested locally with our integration test and manually. 👍

[seh]

Fantastic! Thank you so much, Ed and Lubomir.

[fabriziopandini]

@bart0sh thanks! @neolit123 thanks for testing!
As per slack discussion here
/milestone v1.13
/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bart0sh, fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cmd/kubeadm/OWNERS [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[luxas]

I need to mention I'm everything but happy about this (same for join) from a correctness and code health perspective, but being pragmatic it's a pretty useful feature, and we do appreciate your feedback on what should be improved in kubeadm. So as I'm letting this and the same for join merge, we simply make the general contract that flags should override config.

When this has merged, make sure you open a fresh issue for v1.14 that makes sure we track starting to merge flags with config generically and correctly in the next version.

/lgtm

[bart0sh]

@luxas

we simply make the general contract that flags should override config

I thought it's a common practice for command line utilities, no?

open a fresh issue for v1.14 that makes sure we track starting to merge flags with config generically and correctly in the next version

I'd be happy to work on that. Can you create an issue?

[luxas]

I thought it's a common practice for command line utilities, no?

No, only the kubelet does it correctly. Hence the proposal of https://docs.google.com/document/d/1nZnzJD9dC0xrtEla2Xa-J6zobbC9oltdHIJ3KKSSIhk/edit#.

I'd be happy to work on that. Can you create an issue?

See linked proposal for work items. I'll create an issue.