-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix test names for manifests #71340
fix test names for manifests #71340
Conversation
Hi @yuexiao-wang. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@neolit123 PTAL |
Signed-off-by: yuexiao-wang <wang.yuexiao@zte.com.cn>
/ok-to-test |
/test pull-kubernetes-integration |
1 similar comment
/test pull-kubernetes-integration |
/retest thank you @yuexiao-wang !! |
Got it and thanks |
/assign @timothysc |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timothysc, yuexiao-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: yuexiao-wang wang.yuexiao@zte.com.cn
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix test name from "custom cloudprovider" to "custom cluster-cidr" because it checks for "--cluster-cidr" in kube-controller-manager parameter.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes # kubernetes/kubeadm#1267
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
It can be merged only after the release of 1.13.