Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timeout for testPodFailSubpathError longer to avoid flake #71483

Merged
merged 1 commit into from
Nov 28, 2018
Merged

Fix timeout for testPodFailSubpathError longer to avoid flake #71483

merged 1 commit into from
Nov 28, 2018

Conversation

mkimuram
Copy link
Contributor

What type of PR is this?
/kind bug
/kind failing-test
/kind flake

What this PR does / why we need it:
Fix timeout for testPodFailSubpathError longer to avoid flake in csi e2e subpath tests.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #71433

Special notes for your reviewer:
/sig storage

According to below comment, extending timeout for short term solution for this issue.
#71474 (review)

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. sig/storage Categorizes an issue or PR as relevant to SIG Storage. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 28, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @mkimuram. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 28, 2018
@mkimuram
Copy link
Contributor Author

@saad-ali @msau42

PTAL

@saad-ali
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkimuram, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2018
@msau42
Copy link
Member

msau42 commented Nov 28, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 28, 2018
@msau42
Copy link
Member

msau42 commented Nov 28, 2018

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 28, 2018
@saad-ali
Copy link
Member

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 28, 2018
@msau42 msau42 mentioned this pull request Nov 28, 2018
Closed
@saad-ali saad-ali mentioned this pull request Nov 28, 2018
Closed
@saad-ali
Copy link
Member

/test pull-kubernetes-kubemark-e2e-gce-big

@AishSundar
Copy link
Contributor

/test pull-kubernetes-e2e-kops-aws

@saad-ali
Copy link
Member

/test pull-kubernetes-e2e-gce-100-performance

@AishSundar
Copy link
Contributor

/test pull-kubernetes-integration

@AishSundar
Copy link
Contributor

/test pull-kubernetes-kubemark-e2e-gce-big

@AishSundar
Copy link
Contributor

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit 5dfe48b into kubernetes:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 Awaiting requested review from davidz627

@rootfs rootfs Awaiting requested review from rootfs

Assignees

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

CSI plugin registration can be slow
5 participants
@mkimuram @k8s-ci-robot @saad-ali @msau42 @AishSundar