make bazel not follow the infinite symlink in _output/local/go #71524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ixdy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
ixdy
commented
Nov 28, 2018
ixdy
force-pushed
the
bazel-_output-local-go
branch
from
658d8a7
to
cad43dd
Compare
Otherwise, calling make followed by bazel might fail, requiring one to run make clean first. Additionally, add comments explaining why we must do this.
ixdy
force-pushed
the
bazel-_output-local-go
branch
from
cad43dd
to
e3fac76
Compare
k8s-ci-robot
added
size/S
|
/sig release I've added comments explaining why we're doing this, too. |
k8s-ci-robot
added
sig/release
BenTheElder
reviewed
Nov 29, 2018
| # Using bazel with a recursive target (e.g. bazel test ...) will abort due to | ||
| # the symlink loop created in this function, so create this special file which | ||
| # tells bazel not to follow the symlink. | ||
| touch "${go_pkg_basedir}/DONT_FOLLOW_SYMLINKS_WHEN_TRAVERSING_THIS_DIRECTORY_VIA_A_RECURSIVE_TARGET_PATTERN" |
There was a problem hiding this comment.
upstream doc here: https://docs.bazel.build/versions/master/guide.html#target-patterns
k8s-ci-robot
added
do-not-merge/hold
|
/retest |
|
/retest |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it: without this,
bazelsometimes fails after runningmake, since it trips over the the infinite symlink in_output/local/go/src/k8s.io/kubernetes.Bazel has a new
.bazelignorefile, but it doesn't work for symlink loops, and furthermore it seems to make things even worse, somehow conflicting with theexcludein theall-srcsfilegroup in the rootBUILD.bazelfile.Does this PR introduce a user-facing change?:
/assign @BenTheElder