Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubeadm OWNERS file #71558

Merged
merged 1 commit into from
Nov 30, 2018
Merged

Update kubeadm OWNERS file #71558

merged 1 commit into from
Nov 30, 2018

Conversation

luxas
Copy link
Member

@luxas luxas commented Nov 29, 2018

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

from the kubeadm OWNERS file.

Welcome and congrats new reviewers and approvers!
Thanks for your contributions, and hopefully we'll see you
around again @stealthybox & @xiangpengzhao!

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@kubernetes/sig-cluster-lifecycle
/assign @luxas @timothysc @fabriziopandini

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 29, 2018
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 29, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2018
@luxas
Copy link
Member Author

luxas commented Nov 29, 2018

/priority backlog

I (formally) approve the OWNERS changes in this file
/approve

Putting the hold so we can get the other approvers' approval of this change as well
/hold

@rosti @yagonobre @neolit123 @xiangpengzhao @stealthybox Please ACK or /lgtm this change

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 29, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luxas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fabriziopandini
Copy link
Member

+1 from me
This is a good opportunity to say thanks to @rosti @yagonobre @neolit123 @xiangpengzhao @stealthybox.
Really appreaciated!

@xiangpengzhao
Copy link
Contributor

ACK +1
Thanks folks! Very glad to have been working with you guys! Hopefully I will have more time for kubeadm in the future :)

@rosti
Copy link
Contributor

rosti commented Nov 29, 2018

ACK from me

@yagonobre
Copy link
Member

yagonobre commented Nov 29, 2018 •
edited

ACK

@neolit123
Copy link
Member

LGTM, thanks Lucas.

timothysc
timothysc approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2018
@stealthybox
Copy link
Member

It's been a pleasure contributing so far -- see around you soon!

ack :)
/lgtm

@stealthybox
Copy link
Member

Congrats @neolit123 馃尞!
You've put a lot of work into kubeadm and your approver status is very well deserved ^^

@luxas
Copy link
Member Author

luxas commented Nov 29, 2018

Great, all ACK's needed are here, I'll unhold this
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2018
@neolit123
Copy link
Member

thanks @stealthybox
drop in the meetings or slack when you have more time for kubeadm.
your insights are always valuable!!

@yagonobre
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 30d61f2 into kubernetes:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothysc timothysc timothysc approved these changes

@dixudx dixudx Awaiting requested review from dixudx

@stealthybox stealthybox Awaiting requested review from stealthybox

Assignees

@timothysc timothysc

@stealthybox stealthybox

@fabriziopandini fabriziopandini

@luxas luxas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@luxas @k8s-ci-robot @fabriziopandini @xiangpengzhao @rosti @yagonobre @neolit123 @stealthybox @timothysc