-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #68575: Allow nodeName updates when endPoint is updated. #71605
Merged
k8s-ci-robot
merged 1 commit into
kubernetes:release-1.10
from
liggitt:automated-cherry-pick-of-#68575-upstream-release-1.10
Dec 10, 2018
Merged
Automated cherry pick of #68575: Allow nodeName updates when endPoint is updated. #71605
k8s-ci-robot
merged 1 commit into
kubernetes:release-1.10
from
liggitt:automated-cherry-pick-of-#68575-upstream-release-1.10
Dec 10, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One scenario where nodeName can change for the same ip address is if the endpoints are in hostNetwork mode and nodes are being added/deleted. With the current validation check, if endpoints controller misses a pod delete event, future endpoint updates will never succeed. removed unused helper functions
k8s-ci-robot
added
do-not-merge/cherry-pick-not-approved
Indicates that a PR is not yet approved to merge into a release branch.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
needs-kind
Indicates a PR lacks a `kind/foo` label and requires one.
needs-sig
Indicates an issue or PR lacks a `sig/foo` label and requires one.
needs-priority
Indicates a PR lacks a `priority/foo` label and requires one.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
labels
Nov 30, 2018
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Nov 30, 2018
/assign @thockin @MaciekPytel |
/retest |
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Nov 30, 2018
liggitt
added
kind/bug
Categorizes issue or PR as related to a bug.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
sig/network
Categorizes an issue or PR as relevant to SIG Network.
labels
Dec 6, 2018
k8s-ci-robot
removed
needs-sig
Indicates an issue or PR lacks a `sig/foo` label and requires one.
needs-priority
Indicates a PR lacks a `priority/foo` label and requires one.
needs-kind
Indicates a PR lacks a `kind/foo` label and requires one.
labels
Dec 6, 2018
liggitt
added
priority/critical-urgent
Highest priority. Must be actively worked on as someone's top priority right now.
and removed
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
labels
Dec 8, 2018
MaciekPytel
added
cherry-pick-approved
Indicates a cherry-pick PR into a release branch has been approved by the release branch manager.
and removed
do-not-merge/cherry-pick-not-approved
Indicates that a PR is not yet approved to merge into a release branch.
labels
Dec 10, 2018
liggitt
deleted the
automated-cherry-pick-of-#68575-upstream-release-1.10
branch
April 22, 2019 15:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cherry-pick-approved
Indicates a cherry-pick PR into a release branch has been approved by the release branch manager.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/bug
Categorizes issue or PR as related to a bug.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
priority/critical-urgent
Highest priority. Must be actively worked on as someone's top priority right now.
sig/network
Categorizes an issue or PR as relevant to SIG Network.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #68575 on release-1.10.
#68575: Allow nodeName updates when endPoint is updated.