-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial cherry-pick of #46517 to fix flaky e2e skew tests #71631
Partial cherry-pick of #46517 to fix flaky e2e skew tests #71631
Conversation
To prevent flakiness in kubectl e2e skew tests
/lgtm cc @soltysh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/assign @feiskyer
for 1.12 approval
/priority critical-urgent
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: m1kola, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What type of PR is this?
/kind flake
What this PR does / why we need it:
Partial cherry pick of #46517 on
release-1.12
.Fixes flaky skew tests for kubectl port-forward.
Special notes for your reviewer:
The original PR contains required test changes and new functionality, so it can't be cherry-picked automatically in a whole.
But would be great to have this merged because this type of flakiness in skew tests happens very often. Some recent examples:
kubernetes/kubectl#558 contains more details (start from this comment: kubernetes/kubectl#558 (comment))
Does this PR introduce a user-facing change?:
/sig cli