Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: move test utilites out of /test #71702

Merged
merged 1 commit into from
Dec 5, 2018
Merged

kubeadm: move test utilites out of /test #71702

merged 1 commit into from
Dec 5, 2018

Conversation

yuexiao-wang
Copy link
Contributor

Signed-off-by: yuexiao-wang wang.yuexiao@zte.com.cn

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Move test utilites out of /test to app/util which causes workflow to have a dependency on test/.

Which issue(s) this PR fixes:

Fixes # kubernetes/kubeadm#1257

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 4, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @yuexiao-wang. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 4, 2018
@yuexiao-wang
Copy link
Contributor Author

@fabriziopandini @nebril @liztio PTAL

@yuexiao-wang
move test utilites out of /test
0dc0659 
Signed-off-by: yuexiao-wang <wang.yuexiao@zte.com.cn>
@yuexiao-wang yuexiao-wang mentioned this pull request Dec 4, 2018
Closed
yagonobre
yagonobre reviewed Dec 4, 2018
View reviewed changes
Copy link
Member

@yagonobre yagonobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuexiao-wang
Did you forget to move kubernetes/cmd/kubeadm/test/certs to kubernetes/cmd/kubeadm/app/util/certs?

@neolit123
Copy link
Member

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 4, 2018
@neolit123 neolit123 mentioned this pull request Dec 4, 2018
Closed
@neolit123
Copy link
Member

Did you forget to move kubernetes/cmd/kubeadm/test/certs to kubernetes/cmd/kubeadm/app/util/certs?

i see the files being moved properly:
https://github.com/kubernetes/kubernetes/tree/0dc0659e07e743c605d4fd2e2a66d2bf3342b57b/cmd/kubeadm/test

@neolit123
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 4, 2018
neolit123
neolit123 approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @yuexiao-wang !

@neolit123
Copy link
Member

/approve

@neolit123
Copy link
Member

@yagonobre please LGTM if you think this is good to go.

@yagonobre
Copy link
Member

@neolit123 @yuexiao-wang I missed the file move on the diff, sorry.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, yuexiao-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2018
@yagonobre
Copy link
Member

/retest

@yuexiao-wang
Copy link
Contributor Author

@neolit123 @yagonobre Thanks

@yuexiao-wang yuexiao-wang changed the title [WIP] kubeadm: move test utilites out of /test kubeadm: move test utilites out of /test Dec 5, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2018
@k8s-ci-robot k8s-ci-robot merged commit 0214031 into kubernetes:master Dec 5, 2018
@yuexiao-wang yuexiao-wang deleted the move-test branch December 5, 2018 05:55
@yagonobre yagonobre mentioned this pull request Dec 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yagonobre yagonobre yagonobre left review comments

@neolit123 neolit123 neolit123 approved these changes

@dixudx dixudx Awaiting requested review from dixudx

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@yagonobre yagonobre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yuexiao-wang @k8s-ci-robot @neolit123 @yagonobre