Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow kube-scheduler to tolerate cluster auth config lookup failure #71755

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Allow kube-scheduler to tolerate cluster auth config lookup failure #71755

merged 1 commit into from
Dec 6, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Dec 5, 2018 •
edited

What type of PR is this?
/kind bug

Which issue(s) this PR fixes:
tolerates #71752

1.12 invocations of the scheduler did not require access to the cluster authentication configmap.

1.13 invocations started requiring it if the scheduler is run with access to an in-cluster client. This PR restores the 1.12 behavior.

Does this PR introduce a user-facing change?:

kube-scheduler: restores ability to run without authentication configuration lookup permissions

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 5, 2018
@liggitt
Copy link
Member Author

liggitt commented Dec 5, 2018

/assign @sttts

@liggitt liggitt force-pushed the tolerate-authn-lookup-failure branch from 43081b5 to 416e114 Compare December 5, 2018 19:14
@liggitt liggitt added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Dec 5, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Dec 5, 2018
@liggitt liggitt added this to the v1.13 milestone Dec 5, 2018
@liggitt
Copy link
Member Author

liggitt commented Dec 5, 2018

/retest

1 similar comment
@liggitt
Copy link
Member Author

liggitt commented Dec 6, 2018

/retest

@sttts
Copy link
Contributor

sttts commented Dec 6, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2018
@liggitt liggitt mentioned this pull request Dec 6, 2018
Merged
@k8s-ci-robot k8s-ci-robot merged commit 257a6d5 into kubernetes:master Dec 6, 2018
@liggitt liggitt deleted the tolerate-authn-lookup-failure branch December 7, 2018 01:17
k8s-ci-robot added a commit that referenced this pull request Dec 12, 2018
@k8s-ci-robot
Merge pull request #71806 from liggitt/automated-cherry-pick-of-#7175…
e06c990 
…5-upstream-release-1.13

Automated cherry pick of #71755: Allow kube-scheduler to tolerate cluster auth config lookup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhiljindal nikhiljindal Awaiting requested review from nikhiljindal

@ravisantoshgudimetla ravisantoshgudimetla Awaiting requested review from ravisantoshgudimetla

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liggitt @sttts @k8s-ci-robot