Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sort-by regression #71805

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Fix sort-by regression #71805

merged 1 commit into from
Dec 7, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Dec 6, 2018 •
edited

What type of PR is this?
/kind bug

What this PR does / why we need it:

  • Fixes sort-by regression for table sorter introduced in Improvekubectl get sorting efficiency #70629
  • Makes table sorter behave consistently with normal sorter when fields are missing from objects
  • Adds missing unit tests for TableSorter

Which issue(s) this PR fixes:
Fixes #71753

Does this PR introduce a user-facing change?:

kubectl: fixes regression in --sort-by behavior

/assign @soltysh

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 6, 2018
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 6, 2018
@liggitt liggitt mentioned this pull request Dec 6, 2018
Closed
@liggitt liggitt added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Dec 6, 2018
@k8s-ci-robot k8s-ci-robot removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 6, 2018
@liggitt liggitt added this to the v1.13 milestone Dec 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 6, 2018
@juanvallejo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2018
@liggitt
Copy link
Member Author

liggitt commented Dec 6, 2018

fixed handling of empty lists and added a covering test. PTAL

@liggitt
Copy link
Member Author

liggitt commented Dec 6, 2018

/retest

soltysh
soltysh approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2018
@liggitt liggitt mentioned this pull request Dec 6, 2018
Merged
@k8s-ci-robot k8s-ci-robot merged commit 1cd6ccb into kubernetes:master Dec 7, 2018
@liggitt liggitt deleted the sort-by branch December 7, 2018 01:17
k8s-ci-robot added a commit that referenced this pull request Dec 7, 2018
@k8s-ci-robot
Merge pull request #71820 from liggitt/automated-cherry-pick-of-#7180…
4abb452 
…5-upstream-release-1.13

Automated cherry pick of #71805: Fix sort-by regression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@juanvallejo juanvallejo Awaiting requested review from juanvallejo

Assignees

@soltysh soltysh

@juanvallejo juanvallejo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

kubectl get pods --sort-by no longer sorts correctly
4 participants
@liggitt @k8s-ci-robot @juanvallejo @soltysh