Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply: fix detection of non-dry-run enabled servers #71854

Merged
merged 1 commit into from
Dec 8, 2018
Merged

apply: fix detection of non-dry-run enabled servers #71854

merged 1 commit into from
Dec 8, 2018

Conversation

apelisse
Copy link
Member

@apelisse apelisse commented Dec 7, 2018

Apply only checks that the server supports dry-run in the create path,
not the update path, which is pretty bad.

What type of PR is this?

Uncomment only one, leave it on its own line:
/kind bug

What this PR does / why we need it:
Fixes a bug where apply forgets to check if the server supports dry-run

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

apply: fix detection of non-dry-run enabled servers

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 7, 2018
@apelisse
Copy link
Member Author

apelisse commented Dec 7, 2018

/sig cli
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. area/kubectl approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 7, 2018
@seans3
Copy link
Contributor

seans3 commented Dec 7, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@apelisse
apply: fix detection of non-dry-run enabled servers
f9ca4aa 
Apply only checks that the server supports dry-run in the create path,
not the update path, which is pretty bad.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2018
@apelisse
Copy link
Member Author

apelisse commented Dec 7, 2018

/retest

@seans3
Copy link
Contributor

seans3 commented Dec 7, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2018
@apelisse
Copy link
Member Author

apelisse commented Dec 8, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 9a9497d into kubernetes:master Dec 8, 2018
@apelisse apelisse mentioned this pull request Dec 10, 2018
Merged
k8s-ci-robot added a commit that referenced this pull request Dec 11, 2018
@k8s-ci-robot
Merge pull request #71916 from apelisse/automated-cherry-pick-of-#718…
aa27780 
…54-upstream-release-1.13

Automated cherry pick of #71854: apply: fix detection of non-dry-run enabled servers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mengqiy mengqiy Awaiting requested review from mengqiy

@shiywang shiywang Awaiting requested review from shiywang

Assignees

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@apelisse @seans3 @k8s-ci-robot