Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #71868: Include BGPConfiguration #71918

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Automated cherry pick of #71868: Include BGPConfiguration #71918

merged 1 commit into from
Dec 11, 2018

Conversation

satyasm
Copy link
Contributor

@satyasm satyasm commented Dec 10, 2018

Cherry pick of #71868 on release-1.11.

#71868: Include BGPConfiguration

@satyasm
Include BGPConfiguration
570a611 
Needed for calico 2.x to 3.x upgrade.
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 10, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @satyasm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 10, 2018
@satyasm
Copy link
Contributor Author

satyasm commented Dec 10, 2018

/assign @caseydavenport
/cc @jingax10

cherry pick into 1.11 branch, needs ok-to-test

@foxish
Copy link
Contributor

foxish commented Dec 10, 2018

/ok-to-test

@satyasm, please get lgtm+approve from any of the owners.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 10, 2018
@satyasm
Copy link
Contributor Author

satyasm commented Dec 10, 2018

/retest

@satyasm
Copy link
Contributor Author

satyasm commented Dec 10, 2018

@satyasm, please get lgtm+approve from any of the owners.

Yup, waiting on @caseydavenport

@jingax10
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2018
@satyasm
Copy link
Contributor Author

satyasm commented Dec 10, 2018

/retest

@caseydavenport
Copy link
Member

/lgtm
/approve
/test pull-kubernetes-integration

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caseydavenport, jingax10, satyasm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2018
@foxish foxish added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Dec 11, 2018
@foxish foxish added this to the v1.11 milestone Dec 11, 2018
@foxish foxish added the kind/bug Categorizes issue or PR as related to a bug. label Dec 11, 2018
@foxish foxish added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 11, 2018
@satyasm
Copy link
Contributor Author

satyasm commented Dec 11, 2018

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit 2649948 into kubernetes:release-1.11 Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingax10 jingax10 Awaiting requested review from jingax10

@bowei bowei Awaiting requested review from bowei

@dnardo dnardo Awaiting requested review from dnardo

Assignees

@caseydavenport caseydavenport

@jingax10 jingax10

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@satyasm @k8s-ci-robot @foxish @jingax10 @caseydavenport