Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #71074: Fixed clearing of devicePath after UnmountDevice #72118

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Automated cherry pick of #71074: Fixed clearing of devicePath after UnmountDevice #72118

merged 1 commit into from
Dec 20, 2018

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Dec 17, 2018

Cherry pick of #71074 on release-1.12.

#71074: Fixed clearing of devicePath after UnmountDevice

@k8s-ci-robot
Copy link
Contributor

@gnufied: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement.

The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #71074.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 17, 2018
@k8s-ci-robot
Copy link
Contributor

@gnufied: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 17, 2018
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 17, 2018
@jsafrane
Copy link
Member

godep: Package (k8s.io/klog) not found

@gnufied
Copy link
Member Author

gnufied commented Dec 18, 2018

@jsafrane yeha need to fix those. sorry about it.

@jsafrane @gnufied
Fixed clearing of devicePath after UnmountDevice
ffa171e 
UnmountDevice must not clear devicepath, because such devicePath
may come from node.status (e.g. on AWS) and subsequent MountDevice
operation (that may be already enqueued) needs it.
@gnufied gnufied force-pushed the automated-cherry-pick-of-#71074-upstream-release-1.12 branch from 91330b5 to ffa171e Compare December 18, 2018 15:56
@gnufied
Copy link
Member Author

gnufied commented Dec 18, 2018

/sig storage

@gnufied
Copy link
Member Author

gnufied commented Dec 18, 2018

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@msau42
Copy link
Member

msau42 commented Dec 18, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2018
@saad-ali
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2018
@feiskyer
Copy link
Member

/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 19, 2018
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 19, 2018
@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Dec 19, 2018
@feiskyer
Copy link
Member

@gnufied Could you add a release note in the original PR?

@gnufied
Copy link
Member Author

gnufied commented Dec 19, 2018

@jsafrane is original author of the PR. @jsafrane can you add a release-note to the PR?

@feiskyer
Copy link
Member

@jsafrane is original author of the PR. @jsafrane can you add a release-note to the PR?

Thanks
/release-note

@k8s-ci-robot
Copy link
Contributor

@feiskyer: the /release-note and /release-note-action-required commands have been deprecated.
Please edit the release-note block in the PR body text to include the release note. If the release note requires additional action include the string action required in the release note. For example:

```release-note
Some release note with action required.
```

In response to this:

@jsafrane is original author of the PR. @jsafrane can you add a release-note to the PR?

Thanks
/release-note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feiskyer feiskyer added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 20, 2018
@k8s-ci-robot k8s-ci-robot merged commit f35a4c7 into kubernetes:release-1.12 Dec 20, 2018
@jsafrane
Copy link
Member

jsafrane commented Jan 2, 2019

Release note added to the original PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

@msau42 msau42 Awaiting requested review from msau42

Assignees

@saad-ali saad-ali

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gnufied @k8s-ci-robot @jsafrane @msau42 @saad-ali @feiskyer