Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #72173: make integration/verify script look for k8s under GOPATH #72218: Clean up artifacts variables in hack scripts #72670

Merged
merged 2 commits into from
Jan 11, 2019
Merged

Automated cherry pick of #72173: make integration/verify script look for k8s under GOPATH #72218: Clean up artifacts variables in hack scripts #72670

merged 2 commits into from
Jan 11, 2019

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Jan 8, 2019

Cherry pick of #72173 #72218 on release-1.11.

#72173: make integration/verify script look for k8s under GOPATH
#72218: Clean up artifacts variables in hack scripts

@k8s-ci-robot
Copy link
Contributor

@ixdy: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 8, 2019
@k8s-ci-robot
Copy link
Contributor

@ixdy: This PR is not for the master branch but does not have the cherry-pick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

To approve the cherry-pick, please assign the patch release manager for the release branch by writing /assign @username in a comment when ready.

The list of patch release managers for each release can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 8, 2019
@ixdy
Copy link
Member Author

ixdy commented Jan 8, 2019

Cherry-picking these to enable using pod-utils for verify and integration jobs on release branches.

/sig testing
/priority important-longterm
/kind cleanup

/cc @cblecker @krzyzacy

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jan 8, 2019
@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 8, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2019
@krzyzacy
Copy link
Member

krzyzacy commented Jan 8, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2019
@ixdy
Copy link
Member Author

ixdy commented Jan 8, 2019

/release-note-none

This is only test and verification infrastructure changes.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 8, 2019
@ixdy
Copy link
Member Author

ixdy commented Jan 8, 2019

/assign @MaciekPytel

@cblecker
Copy link
Member

cblecker commented Jan 8, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MaciekPytel
Copy link
Contributor

/assign @foxish

@foxish foxish added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jan 11, 2019
@foxish foxish added this to the v1.11 milestone Jan 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit b7b266f into kubernetes:release-1.11 Jan 11, 2019
@ixdy ixdy mentioned this pull request Feb 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker Awaiting requested review from cblecker

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

@spiffxp spiffxp Awaiting requested review from spiffxp

@zmerlynn zmerlynn Awaiting requested review from zmerlynn

Assignees

@foxish foxish

@krzyzacy krzyzacy

@cblecker cblecker

@MaciekPytel MaciekPytel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ixdy @k8s-ci-robot @krzyzacy @cblecker @MaciekPytel @foxish