Bug fix: ./hack/local-up-cluster.sh is not work on Arm64 platform #72804

lubinsz · 2019-01-11T04:53:31Z

Signed-off-by: Bin Lu bin.lu@arm.com

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
We need to fix it so that we can run e2e test on Arm64 platform.

Which issue(s) this PR fixes:

Special notes for your reviewer:
We can use it to run a local k8s cluster on Arm64 platform.

Does this PR introduce a user-facing change?:
NONE

NONE

k8s-ci-robot · 2019-01-11T04:53:38Z

Hi @lubinsz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lubinsz · 2019-01-11T04:55:00Z

/release-note-none

lubinsz · 2019-01-11T04:57:22Z

/assign dixudx

lubinsz · 2019-01-11T05:34:50Z

/sig cluster-lifecycle

dixudx · 2019-01-11T06:09:05Z

hack/lib/util.sh

@@ -720,8 +720,24 @@ function kube::util::ensure-cfssl {
    cfssldir="${KUBE_TEMP}/cfssl"
  fi

-  mkdir -p "${cfssldir}"
-  pushd "${cfssldir}" > /dev/null
+  case "$(uname -m)" in


We'd better not add another exact same logic method (the same with that in #72772) in hack scripts.

I've created a PR to add a consistent environment. Your PR can rely on this.

dixudx · 2019-01-28T03:29:18Z

/ok-to-test
/lgtm

BenTheElder · 2019-01-28T23:48:17Z

hack/lib/util.sh

+  if [[ "${host_arch}" != "amd64" ]]; then
+    echo "Cannot download cfssl on non-amd64 hosts and cfssl does not appear to be installed."
+    echo "Please install cfssl and cfssljson and verify they are in \$PATH:"
+    echo "export PATH=\$PATH:\$GOPATH/bin; go get -u github.com/cloudflare/cfssl/cmd/..."


nit: should match the lines below (742-743), but doesn't

dims · 2019-01-30T01:43:09Z

/approve

/hold

(hold is for @BenTheElder to look at latest changes)

k8s-ci-robot · 2019-01-30T01:43:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, lubinsz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~hack/OWNERS~~ [dims]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Bin Lu <bin.lu@arm.com>

BenTheElder

/lgtm
Thank you!

BenTheElder · 2019-01-30T02:31:00Z

/hold cancel

BenTheElder · 2019-01-30T02:37:48Z

/priority important-longterm

BenTheElder · 2019-01-30T02:38:19Z

/retest

k8s-ci-robot · 2019-01-30T03:18:07Z

@lubinsz: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-e2e-kops-aws	`44a36ea`	link	`/test pull-kubernetes-e2e-kops-aws`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot requested review from lavalamp and spiffxp January 11, 2019 04:53

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 11, 2019

lubinsz force-pushed the pr_local branch from 655a2cf to a7a2f0b Compare January 11, 2019 04:57

k8s-ci-robot assigned dixudx Jan 11, 2019

k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 11, 2019

dixudx mentioned this pull request Jan 11, 2019

add method to get host os/arch in hack scripts #72807

Merged

dixudx suggested changes Jan 11, 2019

View reviewed changes

lubinsz force-pushed the pr_local branch from a7a2f0b to 28c885d Compare January 18, 2019 05:34

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 18, 2019

lubinsz force-pushed the pr_local branch from bb36eff to 893c8ce Compare January 18, 2019 06:48

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 18, 2019

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2019

lubinsz force-pushed the pr_local branch from 893c8ce to 467045b Compare January 28, 2019 02:18

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2019

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 28, 2019

BenTheElder reviewed Jan 28, 2019

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2019

Bug fix: ./hack/local-up-cluster.sh is not work on Arm64 platform

44a36ea

Signed-off-by: Bin Lu <bin.lu@arm.com>

lubinsz force-pushed the pr_local branch from 467045b to 44a36ea Compare January 30, 2019 01:50

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2019

k8s-ci-robot assigned BenTheElder Jan 30, 2019

BenTheElder approved these changes Jan 30, 2019

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2019

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2019

k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 30, 2019

k8s-ci-robot merged commit adc95eb into kubernetes:master Jan 30, 2019

lubinsz mentioned this pull request Jun 5, 2019

REQUEST: New membership for lubinsz kubernetes/org#887

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug fix: ./hack/local-up-cluster.sh is not work on Arm64 platform #72804

Bug fix: ./hack/local-up-cluster.sh is not work on Arm64 platform #72804

lubinsz commented Jan 11, 2019 •

edited

k8s-ci-robot commented Jan 11, 2019

lubinsz commented Jan 11, 2019

lubinsz commented Jan 11, 2019

lubinsz commented Jan 11, 2019

dixudx Jan 11, 2019

lubinsz Jan 18, 2019

dixudx commented Jan 28, 2019

BenTheElder Jan 28, 2019

lubinsz Jan 30, 2019

dims commented Jan 30, 2019

k8s-ci-robot commented Jan 30, 2019

BenTheElder left a comment

BenTheElder commented Jan 30, 2019

BenTheElder commented Jan 30, 2019

BenTheElder commented Jan 30, 2019

k8s-ci-robot commented Jan 30, 2019 •

edited

Bug fix: ./hack/local-up-cluster.sh is not work on Arm64 platform #72804

Bug fix: ./hack/local-up-cluster.sh is not work on Arm64 platform #72804

Conversation

lubinsz commented Jan 11, 2019 • edited

k8s-ci-robot commented Jan 11, 2019

lubinsz commented Jan 11, 2019

lubinsz commented Jan 11, 2019

lubinsz commented Jan 11, 2019

dixudx Jan 11, 2019

Choose a reason for hiding this comment

lubinsz Jan 18, 2019

Choose a reason for hiding this comment

dixudx commented Jan 28, 2019

BenTheElder Jan 28, 2019

Choose a reason for hiding this comment

lubinsz Jan 30, 2019

Choose a reason for hiding this comment

dims commented Jan 30, 2019

k8s-ci-robot commented Jan 30, 2019

BenTheElder left a comment

Choose a reason for hiding this comment

BenTheElder commented Jan 30, 2019

BenTheElder commented Jan 30, 2019

BenTheElder commented Jan 30, 2019

k8s-ci-robot commented Jan 30, 2019 • edited

lubinsz commented Jan 11, 2019 •

edited

k8s-ci-robot commented Jan 30, 2019 •

edited