Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #72682: Add metrics-port to kube-proxy cmd flags. #72865

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Automated cherry pick of #72682: Add metrics-port to kube-proxy cmd flags. #72865

merged 1 commit into from
Feb 21, 2019

Conversation

whypro
Copy link
Contributor

@whypro whypro commented Jan 13, 2019

Cherry pick of #72682 on release-1.13.

#72682: Add metrics-port to kube-proxy cmd flags.

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 13, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @whypro. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 13, 2019
@whypro
Copy link
Contributor Author

whypro commented Jan 13, 2019

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@whypro: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aleksandra-malinowska
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 14, 2019
@aleksandra-malinowska
Copy link
Contributor

/sig network
/kind bug

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. kind/bug Categorizes issue or PR as related to a bug. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 14, 2019
@whypro
Copy link
Contributor Author

whypro commented Jan 15, 2019

/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-integration

@whypro
Copy link
Contributor Author

whypro commented Jan 15, 2019

ping @lavalamp @thockin

@MrHohn
Copy link
Member

MrHohn commented Jan 17, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2019
@aleksandra-malinowska
Copy link
Contributor

Friendly ping - this didn't make it into 1.13.3, if you want to merge this before 1.13.4, please get approval from SIG

@MrHohn
Copy link
Member

MrHohn commented Feb 11, 2019

/assign @thockin
for sig approval.

@thockin
Copy link
Member

thockin commented Feb 12, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin, whypro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2019
@MrHohn MrHohn mentioned this pull request Feb 19, 2019
Closed
@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 21, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3349b88 into kubernetes:release-1.13 Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@thockin thockin Awaiting requested review from thockin

Assignees

@aleksandra-malinowska aleksandra-malinowska

@thockin thockin

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@whypro @k8s-ci-robot @aleksandra-malinowska @MrHohn @thockin @tpepper