Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #72895 upstream release 1.12 #72994

Merged
merged 2 commits into from
Jan 22, 2019
Merged

Automated cherry pick of #72895 upstream release 1.12 #72994

merged 2 commits into from
Jan 22, 2019

Conversation

bsalamat
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Improve efficiency of preemption logic in clusters with many pending pods.

/sig scheduling
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2019
@bsalamat bsalamat added this to the v1.12 milestone Jan 16, 2019
@bsalamat bsalamat force-pushed the automated-cherry-pick-of-#72895-upstream-release-1.12 branch from 8258c9d to 1f5b962 Compare January 16, 2019 23:01
@wgliang
Copy link
Contributor

wgliang commented Jan 17, 2019

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2019
@feiskyer
Copy link
Member

@bsalamat please fix gofmt errors

@bsalamat bsalamat force-pushed the automated-cherry-pick-of-#72895-upstream-release-1.12 branch from 1f5b962 to 7c5359c Compare January 17, 2019 19:19
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2019
@bsalamat
Copy link
Member Author

@feiskyer Done

resouer
resouer approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@resouer resouer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2019
@bsalamat
Copy link
Member Author

/retest

@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jan 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit b4698f5 into kubernetes:release-1.12 Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@resouer resouer resouer approved these changes

@misterikkit misterikkit Awaiting requested review from misterikkit

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@resouer resouer

@wgliang wgliang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bsalamat @k8s-ci-robot @wgliang @feiskyer @resouer