Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetInformers not called by Cloud-Controller-Manager for out-off-tree cloudprovider #73069

Closed
hello2mao opened this issue Jan 18, 2019 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider.

Comments

@hello2mao
Copy link
Contributor

hello2mao commented Jan 18, 2019

What happened:
When using in-tree cloudprovider, SetInformers will be called by kube controller manager, but it does not work for out-off-tree cloudprovider.

See below at createCloudProvider

package app

func createCloudProvider(cloudProvider string, externalCloudVolumePlugin string, cloudConfigFile string,
	allowUntaggedCloud bool, sharedInformers informers.SharedInformerFactory) (cloudprovider.Interface, ControllerLoopMode, error) {
	
        ....

	if informerUserCloud, ok := cloud.(cloudprovider.InformerUser); ok {
		informerUserCloud.SetInformers(sharedInformers)
	}
	return cloud, loopMode, err
}
@hello2mao hello2mao added the kind/bug Categorizes issue or PR as related to a bug. label Jan 18, 2019
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 18, 2019
@hello2mao
Copy link
Contributor Author

hello2mao commented Jan 18, 2019

/sig cloud-provider
cc @andrewsykim hi, I create a PR trying to fix this. See #73075

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 18, 2019
@hello2mao
Copy link
Contributor Author

Fix in #73075 , close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider.
Projects
None yet
Development

No branches or pull requests

2 participants