Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #72984: kubeadm: wait for the etcd cluster to be available when #73114

Merged
merged 1 commit into from
Jan 21, 2019
Merged

Automated cherry pick of #72984: kubeadm: wait for the etcd cluster to be available when #73114

merged 1 commit into from
Jan 21, 2019

Conversation

neolit123
Copy link
Member

Cherry pick of #72984 on release-1.13.

#72984: kubeadm: wait for the etcd cluster to be available when

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 20, 2019
@neolit123 neolit123 force-pushed the automated-cherry-pick-of-#72984-origin-release-1.13 branch from 4e223a7 to 1c741b6 Compare January 20, 2019 13:16
@neolit123
Copy link
Member Author

/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 20, 2019
ereslibre
ereslibre approved these changes Jan 20, 2019
View reviewed changes
Copy link
Contributor

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neolit123

@neolit123
Copy link
Member Author

/approve
/remove-priority important-soon
/priority critical-urgent
/assign @tpepper @aleksandra-malinowska)

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jan 20, 2019
@ereslibre @neolit123
kubeadm: wait for the etcd cluster to be available when growing it
485d0cb 
When the etcd cluster grows we need to explicitly wait for it to be
available. This ensures that we are not implicitly doing this in
following steps when they try to access the apiserver.
@neolit123 neolit123 force-pushed the automated-cherry-pick-of-#72984-origin-release-1.13 branch from 1c741b6 to 485d0cb Compare January 20, 2019 13:32
@neolit123
Copy link
Member Author

/assign @fabriziopandini
for approve

@fabriziopandini
Copy link
Member

/approve
/assign @timothysc
/assign @detiber

This PR adds a wait loop (timeout 40s) testing the etcd cluster state after a new member is added; this helps in making join --control-plane workflow more robust, especially when growing for 1 to 2 nodes

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2019
rosti
rosti approved these changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@rosti rosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ereslibre and @neolit123 !
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2019
@rosti
Copy link
Contributor

rosti commented Jan 21, 2019

/assign @tpepper @aleksandra-malinowska

@aleksandra-malinowska aleksandra-malinowska added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jan 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit a0ad376 into kubernetes:release-1.13 Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ereslibre ereslibre ereslibre approved these changes

@rosti rosti rosti approved these changes

@detiber detiber Awaiting requested review from detiber

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@timothysc timothysc

@detiber detiber

@rosti rosti

@tpepper tpepper

@aleksandra-malinowska aleksandra-malinowska

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@neolit123 @fabriziopandini @k8s-ci-robot @rosti @ereslibre @timothysc @detiber @tpepper @aleksandra-malinowska