-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing dependency to zookeeper-install #73194
Conversation
/lgtm |
/lgtm cancel |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let us update the VERSION number in https://github.com/kubernetes/kubernetes/blob/master/test/images/pets/zookeeper-installer/VERSION
Not really sure what got changed which is causing this issue. bash is used in https://github.com/kubernetes/kubernetes/blob/master/test/images/pets/redis-installer/install.sh as well. |
@mkumatag I found this peer-finder also install bash in dockerfile:
|
The version should also be bumped here somehow to fix the e2e test:
Maybe this has to be done in a separate PR after the image is build from this PR being merged? |
/test pull-kubernetes-e2e-kops-aws |
/lgtm |
would be great to see this merged soon |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielqsj, ixdy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/sig testing
What this PR does / why we need it:
The
zookeeper-install
image should be able to execute the entrypoint.Which issue(s) this PR fixes:
Fixes #73184
Special notes for your reviewer:
Does this PR introduce a user-facing change?: