Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependency to zookeeper-install #73194

Merged
merged 1 commit into from
Jan 30, 2019

Conversation

danielqsj
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/sig testing

What this PR does / why we need it:

The zookeeper-install image should be able to execute the entrypoint.

Which issue(s) this PR fixes:

Fixes #73184

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 23, 2019
@mkumatag
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2019
@mkumatag
Copy link
Member

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2019
@danielqsj
Copy link
Contributor Author

/retest

Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkumatag
Copy link
Member

Not really sure what got changed which is causing this issue. bash is used in https://github.com/kubernetes/kubernetes/blob/master/test/images/pets/redis-installer/install.sh as well.

@danielqsj
Copy link
Contributor Author

@mkumatag I found this peer-finder also install bash in dockerfile:

RUN clean-install wget bash dnsutils

@mikkeloscar
Copy link
Contributor

mikkeloscar commented Jan 23, 2019

The version should also be bumped here somehow to fix the e2e test:

image: gcr.io/kubernetes-e2e-test-images/pets/zookeeper-installer:1.2

Maybe this has to be done in a separate PR after the image is build from this PR being merged?

@mikkeloscar
Copy link
Contributor

/test pull-kubernetes-e2e-kops-aws

@mkumatag
Copy link
Member

/lgtm

@danielqsj
Copy link
Contributor Author

@ixdy @luxas if you have time, can you help review this? Thanks

@jrake-revelant
Copy link

would be great to see this merged soon

@ixdy
Copy link
Member

ixdy commented Jan 30, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielqsj, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zookeeper-install image doesn't work (bash is missing)
6 participants