Refactor csiDriversStore #73313
Merged
Refactor csiDriversStore #73313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to hide - the mutex handling - the initialization as implementation details. Signed-off-by: Maria Ntalla <mntalla@pivotal.io>
k8s-ci-robot
added
release-note-none
|
We have some evidence that this will be beneficial from the earlier spikes we did over here: |
k8s-ci-robot
added
sig/storage
|
/retest |
|
/restest |
|
/test pull-kubernetes-integration |
|
@hoegaarden |
k8s-ci-robot
added
the
lgtm
|
@hoegaarden since there's no behavior modification, you don't need e2e. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hoegaarden, vladimirvivien The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR does a little bit of refactoring in the
pkg/volume/csipackage, there is no external facing change(¹).With those changes, the mutex handling and initialisation are handled internally and makes them an implementation detail other components do not need to know about and implement.
This is one little stepping stone towards removing any global state in the CSI package. This makes it a bit easier to pass the drivers list around, have it as a member of a struct (
Pluginand/orRegistraionHandler), potentially passing the list around in different functions/methods, ... without needing to care about the mutex.¹ Exception: More types are exported now (
csi.Diver&csi.DriversList) to enable blackbox testing.Special notes for your reviewer:
We want to remove all globals from
pkg/volume/csi, we try to split it into as small PRs as we can. This is only the first of a series of PRs.Does this PR introduce a user-facing change?:
/assign @vladimirvivien
@mariantalla