Importing the latest json patch and set the accumulated copy size limit #73713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@caesarxuchao: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
do-not-merge/release-note-label-needed
caesarxuchao
force-pushed
the
bump-json-patch-again
branch
2 times, most recently
from
e1e5f91
to
6ed8a4b
Compare
liggitt
reviewed
Feb 4, 2019
staging/src/k8s.io/apiserver/pkg/admission/plugin/webhook/mutating/dispatcher.go
Outdated
Show resolved
Hide resolved
caesarxuchao
force-pushed
the
bump-json-patch-again
branch
from
6ed8a4b
to
0b95a4f
Compare
|
/release-note-none |
k8s-ci-robot
added
release-note-none
|
sounds like a good thing to have in 1.14. right? /milestone v1.14 |
caesarxuchao
force-pushed
the
bump-json-patch-again
branch
3 times, most recently
from
1fc1a19
to
3993ce1
Compare
caesarxuchao
force-pushed
the
bump-json-patch-again
branch
from
3993ce1
to
f001f9e
Compare
liggitt
added
kind/bug
k8s-ci-robot
removed
needs-kind
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a json patch from consuming too much memory.
The kubectl patch command implementation also invokes the json patch library to apply patch, but that's only invoked if it's a dry-run or if the local flag is set. I think for those two cases, it's better to not have a limit than having a different limit than the apiserver, so I didn't set the limit.
There are other places import the json-patch lib, but they don't apply the patch, so they don't need to set the limit.
/assign @liggitt @cjcullen
/kind bug-fix
/sig api-machinery
/release-note-none
I didn't write a release note because users shouldn't see a difference. Even without this pull, patches that violate the limit are rejected by the etcd anyway. This pull makes such requests rejected earlier in the apiserver.