Fix MAC filtering in vSphere cloud provider

[frapposelli]

vSphere cloud provider patches node ips only if they're from a mac address that is associated to the VMware OUI, the previous list was missing two allocated OUIs, this led to cloud provider not patching node ips correctly.

What type of PR is this?

/kind bug

/sig cloud-provider
/sig vmware

/assign @andrewsykim @SandeepPissay @dougm

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

MAC Address filter has been fixed in vSphere Cloud Provider, it no longer ignores `00:1c:14` and `00:05:69` prefixes

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frapposelli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/cloudprovider/providers/vsphere/OWNERS [frapposelli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[frapposelli]

this fix should be backported as well.

[frapposelli]

Official list of OUIs: http://standards-oui.ieee.org/oui.txt

[dougm]

Note that a MAC can be manually set with an OUI other than VMware's.

Another option to consider is using the vSphere API instead of net.Interfaces, this method only returns IP address that have a corresponding vSphere virtual NIC device:

https://github.com/vmware/govmomi/blob/e560c7bb1e709826a897c9da4baad0944c2cdda0/object/virtual_machine.go#L254-L259

Though I suppose this isn't an option for in-tree, since nodes don't require vSphere credentials. Maybe something for out-of-tree provider to consider?

[frapposelli]

@dougm AFAIK out-of-tree does not perform this check at all, exactly because MAC addresses can be completely arbitrary on the platform. Performing some form of reconciliation between the vSphere API and the local machine is a very good idea for out-of-tree.

[joshrosso]

I've validated that, without larger code changes, MAC-based OUI filtering is required.

Using https://github.com/joshrosso/kubernetes/commit/5ef48f8d1de112ae56a77f6f20f61fafc9a49855, I built a kubelet image and the result is every interface's IP address was picked up. Including the docker bridge.

After matching similar functionality to this PR via https://github.com/joshrosso/kubernetes/commit/8ecf6cd9b9f75985002de2d805239c8a8b4860c0 I was able to verify the IP was set correctly.

As discussed above this is fragile as non-VMware OUIs could come through the system. Reconciliation against vCenter is highly preferred. However, I understand the constraints making that only plausible for the external provider.

[frapposelli]

/retest

[andrewsykim]

/lgtm

[andrewsykim]

/lgtm

[dougm]

/lgtm

[frapposelli]

/test pull-kubernetes-e2e-gce-100-performance

[frapposelli]

/test pull-kubernetes-integration

[andrewsykim]

This needs to be cherry-picked to previous versions
v1.11: #73825
v1.12: #73826
v1.13: #73827